How to separate more than one "Allowed" Shell command?

joegould82 · August 31, 2017, 2:33pm

I need to run batchfile1.bat and batchfile2.bat at different times, what separation character do I use to add both commands to the “Shell Command Allow List”???

Peter · September 1, 2017, 2:28pm

You will want to use most likely && between commands

I believe that’s the way to do it in cmd on Windows, so it should be fine via shell command in Xibo too.

In 1.8 series there is also ‘Launch the command via Windows Command Line’ checkbox, which will most definitely work, but I suppose it should work in 1.7 as well.

joegould82 · September 1, 2017, 3:51pm

not exactly what I was looking for… I have two different commands that I need to add to the display’s “Allowed Shell Commands”… what separation character does the CMS use to separate the “Allowed” commands?

alex · September 4, 2017, 9:02am

I believe it’s a comma.

github.com

xibosignage/xibo-dotnetclient/blob/develop/Media/ShellCommand.cs#L88


{
    // shell command


    // Is this module enabled?
    if (ApplicationSettings.Default.EnableShellCommands)
    {
        // Check to see if we have an allow list
        if (!string.IsNullOrEmpty(ApplicationSettings.Default.ShellCommandAllowList))
        {
            // Array of allowed commands
            string[] allowedCommands = ApplicationSettings.Default.ShellCommandAllowList.Split(',');


            // Check we are allowed to execute the command
            bool found = false;


            foreach (string allowedCommand in allowedCommands)
            {
                if (_command.StartsWith(allowedCommand))
                {
                    found = true;
                    ExecuteShellCommand();

joegould82 · September 5, 2017, 9:27pm

This is exactly what I wanted and thank you for showing me it was available on github to look the the cs file for the function… I may not need the forum as much now.