Topic Extension: CMS 1.7.4 Dataset View CSS Bug

The Archives Help Topics
1

Continuing the discussion from Possible Bug: CMS 1.7.3 Dataset View CSS:

Hi Peter,

Sorry for opening this again, however after changing the dataset css to what you suggested, it still does not produce desired results or results obtained in 1.6. Please see images below and I am quite positive that it’s a bug or if it’s not then how it was implemented in CMS 1.6 was (in my opinion) the correct implementation.

You will notice that in CMS 1.7.4 (see attached image) layout designer, dataset preview does not cover entire region and also the player (see image) does not scale content to full region’s dimensions.

Basically, what I can make out is that the content is not scaling to full region’s dimension which in my opinion was easier and correct implemented in CMS 1.6.4.

Can Dan/Alex, plz have a look at this ?

If you want, I can export the layout and provide it to you for testing on 1.6.4 & 1.7.4.

Here are the Images:

CMS 1.7.4 Layout Designer

CMS 1.7.4 Player

CMS 1.6.4 Player

Thanks
bTech

2

You would say that the table expanding to 100% height is more important than the text size being the same proportion between the designer and the player?

I would disagree! We had many many comments and concerns about the dataSet functionality because you could get your content looking just how you wanted it in the designer, but on the player it would appear over 4 times smaller. We agreed with these comments and now then designer and player output will be the same.

This allows you to use absolute pixel sizing too - because you know that even though the layout designer window is smaller, it will be rendered as if it was the same pixel size as the final output. I.e. you can add:

#DataSetTableContainer {
 height: <<region height>>px;
}
3

Hi Dan,

I managed to get the table to fit full region’s dimensions by including the following css for that dataset, might help someone:

#content {
width:100% !important;
height:100% !important;
}

#DataSetTableContainer {
 width:100% !important;
 height:100% !important;
}

However, another problem that arose is, on specifying “Rows per page” in dataset view the table’s does not expand to full width or reverts back as if the above css were not applied or does not have any effect.

I tried to investigate the issue using browser css inspector but could not solve it. Could you plz take a look as to why specifying “Rows per page” the table does not expand to full width.

This will help a lot.
Thanks.

4

Sorry, I have not been able to work that out - are you suggesting that with “Rows per page” selected in the previous version, it spread across the whole page?

Thanks,
Dan

5

I am using CMS 1.7.3. The following images should make it clear:

  • Before setting “Rows Per Page”

labelled-before_rows_per_page_setting.png806×457 40.3 KB

  • After setting “Rows Per Page”

labelled-after_rows_per_page_setting.png806×457 82.5 KB

Thanks
btech.

6

I understand what the problem is - but I don’t understand how that could have changed between 1.6.4 and 1.7.4… are you saying that it used to work as you wanted in 1.6.4?

I can’t see any way to expand the table when Rows Per Page is set

7

Yes, when rows per page was set the dataset expanded to full region dimensions and cycled through all the pages. It did not shrink as shown in those images.

I am not sure either what the problem is however it seems more of a JS issue then CSS and I am a no-voice in JS, Could you plz see if some thing can be done about this.

Thanks
btech.

8

I’ve submitted it as a bug for you:

I can’t work out how to fix it at the moment… but it will be looked at for 1.7.5