Thumbnail Display Issue v3.1+

alex · September 21, 2023, 11:12am

I’ve only checked 3.3.8 as that’s the current v3 release, but it does indeed cache that in the CMS library when the thumbnail is generated the first time.

github.com

xibosignage/xibo-cms/blob/release33/lib/Widget/Image.php#L193


      
          
              // Show the image - scaled to the aspect ratio of this region (get from GET)
              return '<div style="display:table; width:100%; height: ' . $height . 'px">
                  <div style="text-align:' . $align . '; display: table-cell; vertical-align: ' . $vAlign . ';">
                      <img src="' . $url . '" />
                  </div>
              </div>';
          }
          
          /** @inheritDoc */
          public function download(Request $request, Response $response): Response
          {
              $sanitizedParams = $this->getSanitizer($request->getQueryParams());
              $this->getLog()->debug('Image Module: download for ' . $this->getMediaId());
          
              $libraryLocation = $this->getConfig()->getSetting('LIBRARY_LOCATION');
              $media = $this->mediaFactory->getById($this->getMediaId());
              $filePath = $libraryLocation . $media->storedAs;
              $this->getLog()->debug('Media Returned: ' . $media->storedAs);
              
              $width = intval($sanitizedParams->getDouble('width'));

That’s the function.

github.com

xibosignage/xibo-cms/blob/release33/lib/Widget/Image.php#L245


      
          $thumbPath = $libraryLocation . 'tn_' . $media->storedAs;
          $proportional = true;
          $width = 120;
          $height = 120;
          
          $this->getLog()->debug('Thumbnail: ' . $thumbPath . ' requested');
          
          // Does the thumbnail exist already?
          $img = null;
          $regenerate = true;
          if (file_exists($thumbPath)) {
              $img = Img::make($filePath);
              if ($img->width() === $width || $img->height() === $height) {
                  // Correct cache
                  $regenerate = false;
              }
          }
          
          if ($regenerate) {
              // Get the full image and make a thumbnail
              $img = Img::make($filePath);

That’s where it’s checking if the file already exists. You’d see those in the CMS library directory as files starting with tn_.