Log verification

Developer Experience
1

Dan, good night.

In the Lib / entity / media.php file we have the following function:

private function moveFile($from, $to)
{
$return = copy($from, $to);

    if (!@unlink($from))
        $this->getLog()->error('Cannot delete file: ' . $to);

    return $return;
}

My question is, should not the error log be this way?
error('Cannot delete file: ’ . $from);

2

It certainly could be - the logging is there more to indicate that there was a problem with the unlink - both from and to are fairly immaterial.

The best thing to do would be to log both I think.

$this->getLog()->error('Cannot delete file: ' . $from . ' after copying to ' . $to);